Gilberto J Requena

Results 8 comments of Gilberto J Requena

This seems like an interesting feature, I would spend some time on it, if the team makes a decision on it.

I could work on this if the OP is not interested in creating the PR.

Hey guys can you give it a look to the open [PR](https://github.com/junit-team/junit5/pull/2978) for solving this issue? It is being open for some time and it is not that big ;)

It seems like [this](https://github.com/junit-team/junit5/blob/e7130723ba11f8a6e14db141f5239d132f8284d4/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/SeparateThreadTimeoutInvocation.java#L42) handling is not needed since it is catching the wrong type of exception and also because the `assertTimeoutPreemptively` handles internally the timeout. Also, I realized that...

@marcphilipp Just want to make sure I got it right, so the proposal is to extend the API and give the possibility to the user of `Assertions` to specify which...

The problem is that it will not be visible for the `engine`, or am I missing something? 😅

I could spend some time on this if there are no objections.

> > @d-william Would you be interested in submitting a PR for this? > > Sorry for the late reply, I think I can handle it if it is still...