Gilad Gray

Results 39 comments of Gilad Gray

yes `enforceFocus` with nested `Overlay`s (select's `Popover` inside a `Drawer`) is the cause here. `enforceFocus={false}` is correct. i wish this had been the default 😕

@adidahiya wooo first @-question in 18 months! i would say yes, but even more important is `autoFocus={false}` which wrecks popover submenus and dropdowns. i often disable it myself immediately because...

there's a `KeyCombo` component that should do what you want. it's not documented but totally exported and ready for use.

this does not require API breaks so it will not happen in 3.0.0

@graysonhicks CSS in JS is not "on the roadmap" because it amounts to a holistic rewrite of each component. it's a future consideration and certainly something we're discussing internally, but...

some thoughts on theming Blueprint from an original author of this library (I left the company in early 2019) who has recently attempted this himself in a non-Palantir codebase. apologies...

@TeaBough would happily review a submission for such a thing! that'd be a cool feature.

@tnrich i was able to resolve this in the select package by disabling `autoFocus` and re-implementing it with `requestAnimationFrame`. https://github.com/palantir/blueprint/blob/develop/packages/select/src/components/select/select.tsx#L200

pretty sure it's released, but that's just in select. i haven't touched the popover logic in some time.

@tnrich might you have time to port this change to Popover itself?