Luigi Teschio

Results 126 comments of Luigi Teschio
trafficstars

Yes! On PR that touches only blocks codebase, only E2E tests regarding blocks run. This happens on other PRs as well, for example: https://github.com/woocommerce/woocommerce/pull/47157

> Is this PR ready to go and do you need my review? I've been getting notifications about this PR for about 3 weeks, I think while it was in...

@nefeline @alexflorisca, Could you take a look at this PR? Thanks! 🙇

> @gigitux Apart from the fact that this PR is currently blocked by #46125, is a review from @woocommerce/rubik necessary given that none of the migrated e2e tests affects the...

Thanks, @WunderBart, for the review! I addressed your feedback!

> > Since the suffix approach is no longer required for environment setup, could we simplify the suffixes to "classic theme" and "block theme"? This would remove the redundant "block_theme_with_templates"...

> looking even further, do we even need the block/classic theme distinction? Do you think it's a useful thing to have? Yeah, good point. I think that the classic/block suffixes...

> OTOH, there are only 11 tests for the classic theme, so I propose discussing the theme-based separation in another PR, if that's OK! 😅 As I mentioned via DMs,...

> As mentioned in Tom's reply. Could you clarify how that would simply the codebase? What I understand from the issues is that it's mostly a UI change (and that's...

> @gigitux @Aljullu can you remind me what logic [like this](https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Blocks/BlockTemplatesController.php#L172-L264) is for again? What would make a template eligible or ineligible for a fallback? I don't recall tbh. From...