Luigi Teschio

Results 126 comments of Luigi Teschio
trafficstars

Thanks, @albarin, for the review! > I think that's the default style for input numbers on Firefox, not saying that is wrong, just wanted to mention it, in case we...

> I'd keep them due to accessibility. Generally, when `Input` style is selected, the quantity field should look and behave like a regular number input field. We may want to...

> @gigitux Here are my two (or few more) cents on the matter: > > 1. Can you elaborate here in a comment or in the PR description what are...

I tested some blocks that are available on [WooCommerce.com ](https://woocommerce.com/product-category/themes/?categoryIds=31380&collections=theme&page=1) | Block Theme Name | Input | Stepper | Result | |--------|--------|--------|--------| | eRide |![image](https://github.com/woocommerce/woocommerce/assets/4463174/52be1550-f377-439e-9b39-c1708033a0bb) | ![image](https://github.com/woocommerce/woocommerce/assets/4463174/18aff266-ca3b-4a93-9992-ee21d63e8151) | 👍 |...

After some discussions (p1716475165372189-slack-C02FL3X7KR6), we've decided to leverage the default WooCommerce I for the `Input` style. This approach eliminates the need for custom styles, reducing potential conflicts with block themes....

Thanks, @albarin, for catching this! I fixed it with [b1c56e5](https://github.com/woocommerce/woocommerce/pull/47664/commits/b1c56e52a7eb55938f41fbe16d5f1108469f14ca) ![image](https://github.com/woocommerce/woocommerce/assets/4463174/3ab5330c-16d6-4ce6-81f9-f81961cda876) ![image](https://github.com/woocommerce/woocommerce/assets/4463174/6f438378-d633-411f-af6d-91968eb65ee4)

Regarding the Safari issue, I did an investigation, and unfortnaly I discovered that if the default WebKit style is disabled with `webkit-appearance:none`, the arrow will not be visible anymore: ![image](https://github.com/woocommerce/woocommerce/assets/4463174/adc75012-2c95-44a8-9246-8e5be898e471)...

> Does it mean that for now the variation picker will stay as is in Safari? Yes!

I have updated the issue title and description to align with the current roadmap.

> @gigitux In the `About` and `Services` categories I see 3 patterns, but in the designs only 2 appear, is that expected? Fixed with [803ca89](https://github.com/woocommerce/woocommerce/pull/48839/commits/803ca894ed3886a3021ab45c50b11996f8789fd9)