Sungho Park
Sungho Park
Fine. I'll add test cases and a use case. Thanks!
@aniketmaurya @Borda I finish this task in PR(https://github.com/Lightning-Universe/stable-diffusion-deploy/pull/265). Can you review it again?
@aniketmaurya I add some tests and it works on my machine with same test command. ```sh coverage run --source muse -m pytest muse tests -v ``` These tests worked well...
Using stable diffusion checkpoint to test function is not good at Github Action. https://github.com/Lightning-Universe/stable-diffusion-deploy/actions/runs/4379968252/jobs/7666492774 Mac instance can be run all the test, but Ubuntu instance can't download checkpoint and run...
I split test function. 1. Testing logic of StableDiffusionServe().is_custom_model(), https://github.com/naem1023/stable-diffusion-deploy/blob/9c9e9b33f638d4abf07dae84df41998a81db434c/muse/components/stable_diffusion_serve.py#L80-L88 2. Testing download diffusion model using stable_diffusion_inference, https://github.com/naem1023/stable-diffusion-deploy/blob/9c9e9b33f638d4abf07dae84df41998a81db434c/muse/components/stable_diffusion_serve.py#L108-L115 The first test runs smoothly in github action. It does not download...
I've resolved all the testing and conflicts. Can you review it again? @Borda @aniketmaurya
I combined all the messy commits using sqush.
@Borda @aniketmaurya HI! I know you're busy, but could you give me some simple reviews? Thanks!
Because of your response, now I totally understand about the history of the works. Thanks a lot!!