Joshua Gigg

I can't change the tests to run natively in PHPUnit 9 as it'll break older PHP versions that rely on older PHPUnit versions. That's the point of simple-phpunit. I'd suggest...

That's what simple-phpunit is doing to the phpunit version it's including. Return types were only introduced in PHP 7, and this project still supports 5.3+.

I believe it's the other way around. It removes the void return type from the PHPUnit code itself.

The listener there is only for deprecation notices, not any help here. The simple-phpunit script if part of the phpunit-bridge, so you should have it somewhere with that package: https://github.com/symfony/phpunit-bridge/tree/5.4/bin

Could the packager script use regex/sed to add the return type for the tests? I assume the actual package won't include the test files.

A patch would work fine. I'd be happy to include it within the project too so it's easier to keep it up to date. I don't imagine those files will...

Would your packaged version run on PHP 5? If so, how are you running phpunit? I can just put the patch in as tests/phpunit8-compatibility.patch (or similar)

Okay, I think your approach of including that patch in the debian repo (especially as you have others) makes sense.

NullPointerException is being fixed now (#515). I also don't think you need https://salsa.debian.org/php-team/pear/php-giggsey-libphonenumber/-/blob/debian/latest/debian/patches/02-debian-test.patch if you are using normal phpunit again

Happy for this to be closed now?