Giampaolo Rodola

Results 377 comments of Giampaolo Rodola

Same problem here.

Why not reusing original stdlib unittests and remove tests relying on "verbose" and "module" parameters and "_source" attribute?

Can we do this by keeping compatibility with Python 2.7? How?

> Oh, didn't realize you still support python 2.7 😮. Also 2.6 😅 I never used type hints but in order to avoid cluttering the code with comments perhaps it’s...

> (but they really don't want to maintain them anymore) What do you mean by that? https://github.com/python/typeshed/commits/master/stubs/psutil/psutil/__init__.pyi Judging from the activity on this file it seems pretty actively maintained.

Can you please update README and CREDITS?

Merged. Thank you Thomas.

The code checks whether the path is a regular file: https://github.com/giampaolo/psutil/blob/c13017f04a721188f4da7822b503d9fad002805d/psutil/_pslinux.py#L2205-L2209 The check is needed because `/proc//fd` can return all sorts of file descriptor types (pipes , unix sockets, directories,...

> Of course ls -l testdir returns EPERM as the directory is not accessible but is a python program using Process.open_files() to get a list of open file descriptions really...

Mmm... is `"hw.cpufrequency"` the only one that fails? Later on we also use `"hw.cpufrequency_min"` and `"hw.cpufrequency_max"`. Do they fail as well? > Sorry that I couldn't provide some of the...