Giamir Buoncristiani

Results 13 comments of Giamir Buoncristiani

Hi @b-kelly, Let me know if there is anything I can do to make your review process easier and prevent this branch from going stale. I tried to outline my...

No problem, @b-kelly. I did not mean to create a sense of urgency. I only wanted to offer support. I appreciate your efforts as a maintainer and I can certainly...

To add to what @dancormier said I think this PR is a great step in the right direction to make our tables more accessible. Thanks for initiating this @allejo! 💛...

@allejo I added your PR in our internal team backlog for visibility (you are tagged there too). I would prefer if we could keep this PR just about the a11y...

Hello @dancormier and @b-kelly, I spent some time doing a high level review of this PR (with the limited context I have). Here are some comments/questions/ideas: - What do we...

> I'd like to tend toward native CSS and reduce Stacks' dependency on a preprocessor . I think the "pseudo" part of PPCP stands out, but I don't personally see...

> FYI https://github.com/testing-library/playwright-testing-library/issues/558 @dancormier thanks for sharing this. It might be worth considering using exclusively playwright to cut down on dev dependencies. I am personally leaning on "WTR+Testing-Library" simply because...

> Should we be committing visual regression testing screenshots to the repo? Storing images in the repo is probably the most pragmatic and simpler approach. That said if you have...

Hi @jwest86, Ben is on holiday this week. I will make sure to bring your question to the attention of the team and we will come back to you next...

@dancormier No conflict, but the branch looked pretty outdated so it might be that some other refactor like the gap/gutter one have affected the visuals.