Giacomo Cirò
Giacomo Cirò
@SkafteNicki could you provide more info about the visual bugs we are trying to avoid? I would like to tackle this issue, and I'd love to have more details.
Thank you! I'll start digging.
I renamed `conda.models.enums.PathType` to `conda.models.enums.PathEnums`. I added the backward compatibility alias right after the class definition `PathType = PathEnum`. I went through the code and inspected each occurence of `PathType`,...
I am left to add the deprecation constant before making the PR ready for review. I am looking into that.
I signed the CLA and I am now waiting for human approval.
I added a new file in the `news/` directory following the template. The PR is now ready for review.
@jaimergp > @conda-bot check I think the check fails becase the [infrastructure PR](https://github.com/conda/infrastructure/pull/1245) has not been merged yet.
> @giacomo-ciro, > > > > I've trigged the full test suite to run. Can you please take a look at it once it's complete to ensure that your changes...
@travishathaway , I rebased the PR since there have been some changes. It's asking some review from code owner. I think you should trigger the test suite again.
> Hi @giacomo-ciro, > > I just wanted to let you know that the test failure here is very likely not due to your changes. I've re-run the test a...