Giovanni Barillari
Giovanni Barillari
@durgeksh access log as of today only regards HTTP requests. Now I see two different points here: - even if supposed to, Granian is not logging the HTTP upgrade request...
> Hi, Can I take this issue ? Thank you Sure thing
Correct, the current implementation doesn't write to access logs. The main thing is that the access log is handled by Python, whereas static files serving happens in Rust code only....
@gaytomycode this looks like a good addition to response types. I'm wondering if it would be better to return a tuple from the route in the form `(snippet, context)`, so...
I agree. But given Granian was designed on top of Hyper, this almost entirely depends on https://github.com/hyperium/hyper/issues/1818
> I'll have to make another manual testing round later on, haven't spent a lot of time on that after the last two commits. Gonna make another code review ASAP....
> I'm sorry for the delay on this PR @gi0baro! np at all, there's no need to rush here :) > Meanwhile, I was thinking a bit about tests. >...
> If possible, I would like to try fixing this issue. @Noahnut sure thing. Feel free to open a PR.
hey @hynek đŸ‘‹ On the keepalive thing: I'm currently working on some code changes that should allow Granian to actually close keepalived connections on shutdown. So that should fix your...
> I'm currently working on some code changes that should allow Granian to actually close keepalived connections on shutdown. So that should fix your case, as well as https://github.com/emmett-framework/granian/issues/548 and...