Ghais Zaher

Results 9 comments of Ghais Zaher

> @ghaiszaher is there still interest in getting this merged? @jamengual yes we are still interested, we'd appreciate any feedback on the current PR.

> I think for JDBC this works by appending ?&TC_REUSABLE=true. I'm using the following: > > ``` > spring: > datasource: > flyway: > url: jdbc:tc:sqlserver:2019-latest://testcontainers/testdb?TC_REUSABLE=true > ``` > >...

Related: https://github.com/reviewdog/reviewdog/issues/1696 Seems like this is fixed with https://github.com/reviewdog/reviewdog/pull/1714 I'll try to upgrade to https://github.com/reviewdog/reviewdog/releases/tag/v0.17.4

@rohan-sca @sergiomr88 please let me know if you still face this issue.

Based on this comment https://github.com/reviewdog/reviewdog/issues/1696#issuecomment-2077370044, it looks like the current solution is to pass the argument `reporter: github-pr-review`. Example: ```yaml - name: ktlint uses: ScaCap/action-ktlint@master with: github_token: ${{ secrets.github_token }}...

@lilincmu @jamengual Since this PR was closed because the repo was deleted from the organization, I raised a new PR: https://github.com/runatlantis/atlantis/pull/2782 which is in a better state now cc @monikma...

> Except for few nits, this looks great to me! Thank you all for your contribution! 🎉 > > One more nit from me is, it might be more readable...

> currently we're forced to use `reporter: github-pr-review` which can lead to it spamming PR comments for the ktlint checks. @rohan-sca this can be removed now, latest reviewdog version provides...

@naivekook could you provide a full example to reproduce? I tried your example and it looks alright to me https://github.com/ghaiszaher/ktlint-issue-test/pull/1#pullrequestreview-1314692154