Grant Hadlich
Grant Hadlich
Consider Checking for Malformed {{ and }} brackets and Give Nice Error in prompt_template_engine.py
https://github.com/microsoft/semantic-kernel/blob/8590ec5e446715e4ec8e0cd7aa59bb54e3f2d09a/python/semantic_kernel/template_engine/prompt_template_engine.py#L161-L172 Consider adding in a check of open / closed ```{{``` and ```}}``` to give a nice error clue: Possible solution if leading ```}}``` is valid: ``` while cursor <...
https://github.com/microsoft/semantic-kernel/blob/8590ec5e446715e4ec8e0cd7aa59bb54e3f2d09a/python/semantic_kernel/memory/volatile_memory_store.py#L35-L38 Possible divide by zero if ```linalg.norm``` returns a 0. Possible fix: ``` # Calculate the L2 norm (Euclidean norm) of the query embedding query_norm = linalg.norm(embedding) # Calculate the...