Oliver Tale-Yazdi

Results 425 comments of Oliver Tale-Yazdi

> Minimal diff makes sense, but if the features are already formatted according to `zepter f f` then it seems like `lint --fix` shouldn't break this? Hm yes, good idea....

Actually just adding a `,` does not work in the case that the line would become longer than the 80 chars since then it has to do a line-break instead....

Yes thanks for the report. This is indeed the case. I will change the behaviour to fix this as well - last time i did we did not need it...

I would also like to move to GitHub Actions as they integrate better into the workflow.

The units are now `K`, `M`, `G` and `T`. In the future some others could be added as well, especially with the WeightsV2.

Maybe as workaround you can try to enable the feature on the crate directly, since rust feature unification should then merge those. Just make sure to use `resolver = 2`...

Depends on what features exactly. I assume that some of them would clash names, but for the big ones it should work. What features do you need? `insecure_zero_ed` i guess,...

Not sure i get the outcome of this discussion. So we do add features like this: `"pallet-session+historical" = ["pallet-session/historical"]` To the umbrella crate, yea? This would then allow downstream to...

I think that does actually not work for crates that you want to publish. But will double-check. If we could align ALL sdk crate versions then it would also be...

Yes I think you got it right. You can exclude shared features like `runtime-benchmarks`, `try-runtime` and `std`. Just take a look at the umbrella `Cargo.toml`. We can also go with...