Gil Aviv comments

Results 6 comments of


Gil Aviv

populate_token_attributes() ValueError for float expires_at values

> hey, can i have this issue? I'm just starting with open source, so this will be a good start ig. @default-303 go for it!

populate_token_attributes() ValueError for float expires_at values

> @ggiill hey, can i get a review ? > lmao its been a month even i forgot abt it. @default-303 I'm not a maintainer - pinging @JonathanHuot. You probably...

data source google_project does not check for space at end of project_id

I was looking for a first issue and found this one. Looks like the `resourceGoogleProject` `project_id` schema field's `ValidateFunc` ([link](https://github.com/hashicorp/terraform-provider-google/blob/fd9dab7d615f8331dfc65d6f898365777e6f1ae5/google/resource_google_project.go#L49)) doesn't get copied in the `datasourceSchemaFromResourceSchema` [function](https://github.com/hashicorp/terraform-provider-google/blob/fd9dab7d615f8331dfc65d6f898365777e6f1ae5/google/datasource_helpers.go#L16). (This has wider...

data source google_project does not check for space at end of project_id

> I was looking for a first issue and found this one. > > Looks like the `resourceGoogleProject` `project_id` schema field's `ValidateFunc` ([link](https://github.com/hashicorp/terraform-provider-google/blob/fd9dab7d615f8331dfc65d6f898365777e6f1ae5/google/resource_google_project.go#L49)) doesn't get copied in the `datasourceSchemaFromResourceSchema` [function](https://github.com/hashicorp/terraform-provider-google/blob/fd9dab7d615f8331dfc65d6f898365777e6f1ae5/google/datasource_helpers.go#L16)....

data source google_project does not check for space at end of project_id

> > I was looking for a first issue and found this one. > > Looks like the `resourceGoogleProject` `project_id` schema field's `ValidateFunc` ([link](https://github.com/hashicorp/terraform-provider-google/blob/fd9dab7d615f8331dfc65d6f898365777e6f1ae5/google/resource_google_project.go#L49)) doesn't get copied in the `datasourceSchemaFromResourceSchema`...

Allow Tesla middleware to be configured

I'm getting a timeout somewhere in `Enforce.OAuth.get_token` or `ExForce.versions`, and, since there is no ability to configure the middleware in `ExForce.Client.Tesla.build_oauth_client`, I can't trace where that timeout is coming from....