Gaetano Giunta

I also do not see any phpdoc paragraph mentioning what the timestamp is supposed to be

No specific part. I just think that the fact that we are now storing the timestamp of midnight-in-utc-timezone should be documented clearly. Ideally both in the online docs and in...

Let me disagree with you. 1. in general, documenting what values are stored in the database *is* valuable to developers who use the platform. Some of them might want to...

About transaction usage: 1. they actually introduce CONTENTION. The db will most of the time be slower, not faster because of them. 2. never, EVER introduce transactions for anything else...

PS: I checked the code. it seems that an outher transaction is indeed missing, and I surmise it should be there, in validateInput() :-(

Nitpick, but why not keep the variable names the same as they where ? It would make it easier to 'get' what has changed and what not

My 2c: this code seems a bit too complex for the problem at hand - I do not think it warrants adding apis inside the clusterfilehandler (think about oracle support...

I was thinking along the same lines...

@bdunogier I'm still waiting for the blogpost explaining how to set up phpstorm so that all the jira+github dance is done automagically for you ;-)

All comments taken into account - please review again