ezpublish-legacy icon indicating copy to clipboard operation
ezpublish-legacy copied to clipboard

Fix EZP-16913: cronjobs/workflow.php, not enough rights to execute opera...

Open gggeek opened this issue 12 years ago • 6 comments

...tion

gggeek avatar Jul 16 '13 09:07 gggeek

+1 on the principle, but please take my comments into account.

@bdunogier @dpobel @patrickallaert @yannickroger @andrerom ?

lolautruche avatar Jul 16 '13 09:07 lolautruche

Same as @lolautruche , +1 on the principle once the CS & todo have been addressed.

A couple little details for future requests:

  • always add an HTTP link to the issue on JIRA (to save a couple seconds per reviewer)
  • if applicable, and it usually is, summarize the issue (one, two sentences top) and how the PR solves it.

This really helps into getting more reviews, and it never hurts to summarize for yourself what you did :-)

bdunogier avatar Jul 16 '13 10:07 bdunogier

@bdunogier I'm still waiting for the blogpost explaining how to set up phpstorm so that all the jira+github dance is done automagically for you ;-)

gggeek avatar Jul 16 '13 12:07 gggeek

+1, provided that you rebase (fixup) your commit into one commit and ensure you have "Fix EZP-16913: cronjobs/workflow.php..." in the title.

patrickallaert avatar Aug 07 '13 11:08 patrickallaert

All comments taken into account - please review again

gggeek avatar Oct 21 '13 09:10 gggeek

You forgot @andrerom 's comment. Except that +1

yannickroger avatar Oct 22 '13 08:10 yannickroger