ezpublish-legacy
ezpublish-legacy copied to clipboard
Fix EZP-16913: cronjobs/workflow.php, not enough rights to execute opera...
...tion
+1 on the principle, but please take my comments into account.
@bdunogier @dpobel @patrickallaert @yannickroger @andrerom ?
Same as @lolautruche , +1 on the principle once the CS & todo have been addressed.
A couple little details for future requests:
- always add an HTTP link to the issue on JIRA (to save a couple seconds per reviewer)
- if applicable, and it usually is, summarize the issue (one, two sentences top) and how the PR solves it.
This really helps into getting more reviews, and it never hurts to summarize for yourself what you did :-)
@bdunogier I'm still waiting for the blogpost explaining how to set up phpstorm so that all the jira+github dance is done automagically for you ;-)
+1, provided that you rebase (fixup) your commit into one commit and ensure you have "Fix EZP-16913: cronjobs/workflow.php..." in the title.
All comments taken into account - please review again
You forgot @andrerom 's comment. Except that +1