Gaetano Giunta

Results 283 comments of Gaetano Giunta
trafficstars

I do agree that simplicity and not having to carry around BC hacks are worthy goals. I still am not convinced about adding a `$backwards_compatible_mode` flag, though. About subclasses and...

-1. We should quote special chars instead of stripping them out. Esp. if this is done pervasively. Do you prohibit single quotes chars from ever being stored in varchar fields...

ps: I agree about filtering out a very limited set of characters, but not fe. '['. Also, I'd try to push any stripping to the kernel, so that the data...

PS: not sure if this is the same, but it feels related to issues #341 (and #38 )

I would not add any further layers to the Filesystem driver, but rather add a separate Flysystem driver. The reason is simple: 1. race conditions are hard enough to debug...

Note: a workaround is to set by hand in the yml config, in the desired capabilities, tunnel-identifier to an empty string

If accepted, please port this to ezpublish-kernel as well :-)

Cleaned up, ready for further review and merge. Let me know if you'd like me to rebase.