Gil Forsyth

Results 181 comments of Gil Forsyth

This is great! Thanks @pdet -- Looking at query 03 right now -- that looks like an issue on the Ibis side -- I can't round-trip that one and I'm...

> I did some digging on Q03, and it seems to me that the positional values of the join conditions are coming slightly off from ibis, not sure if that's...

Sure, so from `proto` which is the raw byte-string, you can do the following: ```python from ibis_substrait.proto.substrait import plan_pb2 plan = plan_pb2.Plan() plan.ParseFromString(proto) from ibis_substrait.compiler.decompile import decompile (result,) = decompile(plan)...

Yeah, I just found that missing dispatch rule -- just got merged in.

ok, yeah, you can update to 2.9.6 now and it will handle the varchar dispatch

> I did, now they break for different reasons. that's progress! I ran into this yesterday trying to deserialize messages from `duckdb`. I think the `duckdb` substrait plans are missing...

I'll write more later (sorry, work is very busy right now), but I'm generally in favor of making things more modular and decoupling the back ends. One thing I'm not...

> If you mean the release process, it would be automated. Splitting the packages helps reducing the CI run time as well. No, the release is the easy part, I'm...

I still don't see any benefit to having the decoupled backend live in a separate repo, given the challenges it presents otherwise. So I'm a big +1 on the decoupling,...

> Having separate package makes easier for it to be installed with package managers and as I have mentioned reduced testing time. I think I'm still not being clear --...