gfgtdf

Results 363 comments of gfgtdf

hmm not sure what the correct fix here would be, we couldof course make the engine generate a [leader] tag when x,y are present in mp, but im not sure...

> ... So I don't think it's clear-cut whether a runner or rider would win in a marathon. There actually exists a ma vs horse marathon https://en.m.wikipedia.org/wiki/Man_versus_Horse_Marathon

looks correct to me (it seems to replace the advancemnts instead of adding but maybethat actually makes more sense in most cases)

this shouldn't be backported, its not a bugfix and the chances it changes behavior are rather high

i wouldn't call is a bug because map generation happens clearly before scenariolevel [lua] tags and prestart events, so the quoted line in the wiki page doesn't guarantee that it...

> given that map generation runs before you even see the OptionWML. this is true for map_generation in [multiplayere] but not in [campaign] iirc, (so if we impleemnt this, this...

> For WC specifically is it important that the bonus generation happens at map generation time? I think The main reason why this happens at map generation time is performance:...

thinking about it, we could also move half of it to lua (the first filter), and make the actual placement in the scenaio code

> Can one add from UMC a custom entry in the UI to what is shown behind the map generator settings button? Partly, the (lua) map gnerator code can add...

the error message clearly points to this line https://github.com/wesnoth/wesnoth/blob/32a1fa0c8a9aa120160fc37d3cd817d5edce588a/src/terrain/builder.cpp#L825 and it seems like that function is only used when parsing the `map=` attribute in `[terrain_graphics]`