Getabalew
Getabalew
The save Button is _specifically responsible_ for only changing the room name. The notification preference gets updated when it is **picked**.
> Still looking for proposals **Proposal** Here is pseudo code I approach this by using state. first should check if the user is online if user is online save the...
### Proposal It is quite interesting to see this detailed comment https://github.com/Expensify/App/blob/c02031489b46200f95d19bfda1e0c048cb99bb45/src/components/Hoverable/index.js#L62-L67 What do we miss? https://github.com/Expensify/App/blob/c02031489b46200f95d19bfda1e0c048cb99bb45/src/components/Tooltip/index.js#L187-L192 ```diff + resetsOnClickOutside={true} ``` https://github.com/Expensify/App/blob/c02031489b46200f95d19bfda1e0c048cb99bb45/src/components/Hoverable/index.js#L71-L78 ```diff - if (this.wrapperView && !this.wrapperView.contains(event.target) && this.props.resetsOnClickOutside)...
> @chiragsalian I like @getusha's [proposal](https://github.com/Expensify/App/issues/12025#issuecomment-1305714746) +1 > > ribbon eyes ribbon C+ reviewed > > @getusha I'd split those conditions into two if statements for better readability. That sounds...
Thank you @chiragsalian @rushatgabhane for assigning me. I will apply for the job on upwork now. the price is not up to date on UW hope it will get updated...
Applied. Will submit the PR in short.
@laurenreidexpensify Thanks Accepted.
@shubham1206agra I am not able to reproduce this on staging.
Still trying to reproduce this, will try to provide an update by tomorrow.
## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...