Dave Smith

Results 48 issues of Dave Smith

## What? Adds dependency to re-run selectors if viewport changes. ## Why? See review comments in https://github.com/WordPress/gutenberg/pull/45591#discussion_r1024239215 ## How? Add `isLargeViewport` to `useSelect` deps. ## Testing Instructions ### Testing Instructions...

## What? ⚠️ This is currently a WIP and should be reviewed with that in mind. Design/CSS input appreciated. Implements a accordion-like panel and toggle for link settings. All settings...

Needs Design Feedback
[Feature] Link Editing

## What? Makes it impossible to drag a block from the Navigation block list view editing mode into the editor canvas. Closes https://github.com/WordPress/gutenberg/issues/46994 ## Why? As shown in https://github.com/WordPress/gutenberg/issues/46994 it's...

[Type] Bug
[Feature] Drag and Drop
[Block] Navigation

As reported in https://github.com/WordPress/gutenberg/issues/46939#issuecomment-1374652632 moving from auto-menu (Page List menu) to having a Nav Menu created when you insert a block is confusing without context. We need to provide context...

Accessibility (a11y)
[Block] Navigation
[a11y] Labelling

As reported in https://github.com/WordPress/gutenberg/issues/46939#issuecomment-1376732975 by @talldan: > there are some missing options for some blocks (Page List children don't have an "Edit block" button), screen reader users may wonder why...

[Type] Bug
Needs Accessibility Feedback
[Block] Navigation
[a11y] Labelling

Currently when using a keyboard (or assitive tech) to use the Nav block's list view editing focus is not managed as you'd expect. Clicking "Edit" on a node causes the...

[Type] Bug
Accessibility (a11y)
[Block] Navigation
[a11y] Keyboard & Focus

It appears that the components _within_ the `` for nodes in the offcanvas experiment are `aria-hidden`. Does this make the node always hidden to screen readers? I seem to remember...

[Type] Bug
Accessibility (a11y)
Needs Accessibility Feedback
[Type] Experimental

As reported in https://github.com/WordPress/gutenberg/issues/46939#issuecomment-1376732975 by @talldan > each item in the off canvas is announced as a link, but those links don't do anything when selected (the functionality was intentionally...

[Type] Bug
[Block] Navigation
[a11y] Labelling

Currently selecting a search suggestion within the Link Control component will automatically apply that link and close the UI. @joedolson is suggesting that instead the suggestion should be selected but...

Accessibility (a11y)
Needs Design Feedback
[Feature] Link Editing

## What? In Zoomed out mode: - disable all blocks that are not "the main content" (a new selector is added for this) - e.g. header, footer...etc - allow basic...