Gareth Estchild

Results 16 comments of Gareth Estchild

Notes I've made that will be relevant to some of the above issues (will add to the appropriate tickets when they are created) # Notes on Body.tsx ## Filtering body...

More notes: ## FeaturedMedia/HeroPicture We can pass FeaturedMedia and HeroPicture props into the `` component. N.B. It will display both if they exist. ### HeroPicture This is used in a...

Closing as all this work is either completed or covered by separate issues

No new insight really. There's a potential solution if we make the viewer capable of displaying the pdfs and videos, which I was looking at as part of the born...

FYI this might need a discussion. [We used to prevent this from happening](https://github.com/wellcomecollection/wellcomecollection.org/pull/4437) when the unusual hours were of type 'other, but then [that decision was reversed ](https://github.com/wellcomecollection/wellcomecollection.org/pull/8829) presumably for...

Not using the tabs pattern at all. Just having the aria-controls property on the tab links and the relevant id and aria-hidden properties on the tab content. Without js they...

One of the downsides of not following the tab pattern is that a user would have to tab through each tab before getting to the tab content

I think it's still something worth doing, but probably not high priority

Audio player labels were updated in #10312

Not as straightforward as first thought as would still require separate licenses for JAWS: https://assistivlabs.com/support/jaws-license So maybe a VM everyone can access is still a better solution?