Gert Sønderby
Gert Sønderby
I like this idea. At best if you can test both positively or negatively, to ascertain that it will complain where you need it to, and leave it where it...
Notably, this bug seems to only occur in Powershell (specifically, the 'GitHub for Windows' Git Shell). Not sure what it would take to replicate elsewhere.
Confirmed as happening (with slightly different colors) in default Powershell (w/o GitHub extensions). Commenting out `node_modules/magicpen/lib/AnsiSerializer.js:131`appears to solve the problem.
That had no effect that I could discern. Still a discolored background.
Ah, of course. (It's been too long since I worked on Atom grammar.) I do notice that using 'styled' instead of 'transition' works. You do special tricks in the grammar...
It refers to [`styled-transition-group`](https://github.com/gabiseabra/styled-transition-group). The highlighting is the same AFAIK, it just adds a few pseudo-class selectors to handle the transition states from the encapsulated `react-transition-group CSSTransition`component. A simple alias...
I'd add the caveat that location state should only be updated after completing any and all exit routes. Otherwise, I am in agreement.
Oh, and I worked around this issue by using `page.current` in the cases where I needed to extract the current location. This will yield the entire path, including hash and...
I'm poking through the code now. Maybe separate the exits and route callbacks to either side of the history push, and ensure that interruption of exits also intercepts the push?
This seems to intersect somewhat with #193. I'm going to look at fixing both.