Gerrit Holl

Results 120 comments of Gerrit Holl

As for where to host them: how about adding them on figshare under the keyword [Pytroll](https://figshare.com/search?q=:keyword:%20%22Pytroll%22)?

Although tests appear to pass, this still fails in practice: ``` Traceback (most recent call last): File "/home/gholl/checkouts/protocode/avhrr-a-or-b.py", line 13, in sc.load(["3a", "3b"]) File "/home/gholl/checkouts/satpy/satpy/scene.py", line 1154, in load self._read_datasets_from_storage(**kwargs)...

I have a case where `self.active_channels == {'1': True, '2': True, '3a': True, '3b': True, '4': True, '5': True}` and `self._is3a.sum() == 0`. This crashes my code (see above) but...

Yes. `hrpt_noaa19_20210423_1411_62891.l1b`

Maybe it got fixed and I unfixed it in this PR…

It is pointless to set `start_time` and `end_time` in the file handler, because the attributes are overwritten in `yaml_reader.FileYAMLReader._load_dataset_data`: https://github.com/pytroll/satpy/blob/eb2036ed7edf9c82d554c68437ed20ea28012439/satpy/readers/yaml_reader.py#L711-L718 Why is the `FileYAMLReader` doing this?

If I remove lines 716 and 717, four unit tests fail. If I make them conditional upon those attributes being not yet present, all unit tests still pass.

It still fails on multiple files. Although the `start_time` and `end_time` attributes get calculated correctly here: https://github.com/pytroll/satpy/blob/eb2036ed7edf9c82d554c68437ed20ea28012439/satpy/readers/file_handlers.py#L97-L98 they get overwritten with the wrong information later in the some function: https://github.com/pytroll/satpy/blob/eb2036ed7edf9c82d554c68437ed20ea28012439/satpy/readers/file_handlers.py#L128

Meh. It appears to work now (as far as data in the file are correct), but for the purposes for which I wrote https://github.com/pytroll/trollflow2/pull/112 it's still not quite good enough...

This PR triggers a `struct.error` in `pyninjotiff` under some circumstances: MCVE --- ```python from satpy import Scene from satpy.utils import debug_on; debug_on() fn = ["/media/nas/x21308/scratch/AAPP-processed/hrpt_noaa19_20210508_1435_63129.l1b"] fn_out = "{start_time:%Y%m%d%H%M}-{platform_name}_{sensor}_{area.area_id}_{name}.tiff" sc =...