Germán Martínez
Germán Martínez
make `execTransaction` payable
Add a `claimAll()` method that transfers all the token balances from the Safe Proxy contract back to the Safe Proxy owner.
Right now, even if the CPK runs as a Safe or standalone app, it requires an Ethereum provider (web3 or ethers) passed as a parameter in the EthAdapter constructor. -...
**Description** We should offer better developer support. This should include a truffle box, a motivation. **Why?** TBD **Open questions/ Notes**
Sometimes tests fail in Travis when calling the relay service. This is the error message: ``` FetchError: invalid json response body at reason: Unexpected token < in JSON at position...
If we are updating the CPKFactory contract at some point, we should track versions
## Situation locally / in Travis The CPK tests uses the `cpk-test` branch of the Safe Relay Service, which has this conditions commented: https://github.com/gnosis/safe-relay-service/blob/cpk-test/safe_relay_service/relay/services/transaction_service.py#L388 This is necessary because the apps...
Check https://tools.ietf.org/id/draft-knodel-terminology-00.html#rfc.section.1.1.1 - Use inclusive language (README.md, new issues, etc.) - Review branch names (*master* to *main*, etc.) - Review code variables (*masterCopy* to *implementation*, etc.)