germanvazquez-rfk comments

Results 6 comments of


                                            germanvazquez-rfk

Example 03 defines an incorrect FieldsKey func

I started using it in a project. I am totally aligned with having the context within each log call. In fact I required the contest because I am instrumenting the...

Example 03 defines an incorrect FieldsKey func

great to hear! I am using also "WithField" a lot. I don't very much like "WithFields" cause it is too verbose to create the map every time I need to...

Example 03 defines an incorrect FieldsKey func

I see. You use it when you need to collect info before calling the log.Info. You are not using gournal there, arent you?

Example 03 defines an incorrect FieldsKey func

But you are not changing the gournal.Entry interface no? It will still receive as first parameter context.context? I ask because I am using that interface and I am instrumenting the...

Example 03 defines an incorrect FieldsKey func

not an open source project

Example 03 defines an incorrect FieldsKey func

I see. Those are cool additions, having 0 overhead and memory allocations is excellent. Anyway, the change in the signature for ```Info(ctx context.Context, msg string, args ...interface{})``` is harmless, it...