Gerhard Olsson
Gerhard Olsson
If noone has any other preferences, I plan to add an extra searchbox to diff.
> My 2ct: This feature seems to be pretty related to the "Find" function - particularly to "Find all" in IDEs. It is similar to Find all, but only for...
Implemented a searchbox. I believe this ready for review and inclusion, but there are some discussion points: * mstv wanted to search with a popup instead. That could be added...
> > Will squash if mstv agrees > I have not looked into the code yet. If you have not reviewed the previous code, I assume I can squash. >...
> As an idea, maybe we could have a single dropdown It is useful to filter grep files too, grep and filter are not exclusive. The POC I had initially...
> Having it in one line with "::" feels too cryptic to me. A toggle button in the upper right corner would make it discoverable. (Please use `RuntimeSetting` in order...
Pushed an update. This PR is now dependent on #11590, it uses the Git coloring. But I believe this PR works as I intend it too. I do not plan...
Implemented a popup to search in (with the searchbox optional). Pushed to tmp/git-coloring. If #11590 is progressing, I will update this PR, including screenshots.
> The grey placeholder text label problem (oversized) was there before too, but that didn't manifest visibly until this change. The label padding must be changed from 4->2 (but 15+2*4=23...
> I've manged to fix the label in my build by reverting these lines from a pretty recent PR https://github.com/gitextensions/gitextensions/pull/11472/files#diff-5cb23b1d441e66ddc2a3b26759cf7c0119dcf370010baff9cb2654611bdd891aR121-R124 That had other issues I believe. Fix (as well for...