Gergely Fábián

Results 122 comments of Gergely Fábián

Updated test for Scala 2.13.

@Godin, @marchof Is this change on its own ok, or would you prefer creating already a PR together with the Scala filtering changes for case classes? My Scala changes are...

Interestingly, the file that is missing for Java 17 is also not there for Java 11: ``` $ ls bazel-out/k8-fastbuild/bin/example-maven/test.runfiles/scala_example/example-maven/ example-maven.jar example-maven-offline.jar test test.args test.jar test_wrapper.sh ```

I've modified JacocoCoverageRunner locally to add some debugging: ``` System.out.println("metadataFileFinal: " + metadataFileFinal); System.out.println("metadataFilesFinal: " + (metadataFilesFinal == null ? null : Arrays.toString(metadataFilesFinal))); if (metadataFileFinal != null || metadataFilesFinal !=...

In JacocoCoverageRunner: ``` private static URL[] getUrls(ClassLoader classLoader, boolean wasWrappedJar) { URL[] urls = getClassLoaderUrls(classLoader); System.out.println("wasWrappedJar: " + wasWrappedJar); System.out.println("urls: " + (urls == null ? null : Arrays.toString(urls))); ```...

Modified another method in JacocoCoverageRunner: ```java private static URL[] getClassLoaderUrls(ClassLoader classLoader) { if (classLoader instanceof URLClassLoader) { System.out.println("classLoader is instanceof URLClassLoader"); return ((URLClassLoader) classLoader).getURLs(); } // java 9 and later...

JacocoCoverageRunner debugging changes are here: https://github.com/gergelyfabian/bazel/tree/jacocorunner_debugging Built JacocoCoverageRunner with: ``` bazel build src/java_tools/junitrunner/java/com/google/testing/coverage:JacocoCoverage_jarjar_deploy.jar cp bazel-bin/src/java_tools/junitrunner/java/com/google/testing/coverage/JacocoCoverage_jarjar_deploy.jar ~/opt/bazel-scala-example/tools/JacocoCoverage_jarjar_deploy.jar && chmod +w ~/opt/bazel-scala-example/tools/JacocoCoverage_jarjar_deploy.jar ``` In bazel-scala-example select java_17 branch and uncomment jacocorunner option...

@liucijus , what do you think, is this a rules_scala or Bazel bug?

Steps to reproduce with custom jacocorunner changes: ``` cd ~/opt git clone https://github.com/gergelyfabian/bazel-scala-example git clone https://github.com/gergelyfabian/bazel cd bazel git checkout jacocorunner_debugging bazel build src/java_tools/junitrunner/java/com/google/testing/coverage:JacocoCoverage_jarjar_deploy.jar cp bazel-bin/src/java_tools/junitrunner/java/com/google/testing/coverage/JacocoCoverage_jarjar_deploy.jar ~/opt/bazel-scala-example/tools/JacocoCoverage_jarjar_deploy.jar && chmod +w...

Can the following issue and fix be related? https://github.com/Col-E/Recaf/issues/312 https://github.com/Col-E/Recaf/commit/2561d92d72227671655597d6ad0f137ae2802a1f