kgl

kgl copied to clipboard

Hi, My name is Eugene. I am developing WorldWindKotlin multiplatform 3d Globe visualization library and I am searching GL abstraction for Android GLES20, WebGL and Jogl. Your library looks like...

ComBatVision

Fixes #18 https://registry.khronos.org/OpenGL-Refpages/gl4/html/glTexImage2D.xhtml#notes

wakaztahir

Allow passing bitmap as TextureResource in android target

1

This pull request required some changes, some methods had to be introduced in the TextureAsset interface which is implemented by TextureResource, It makes the code in TextureAsset a tiny bit...

wakaztahir

Introduce tex sub image 2d

1

Fixes #21 It doesn't provide IOS implementation (I work on windows)

wakaztahir

Fixes #17 - Changes previous constants to inline val getters, So they are non existent - Puts new constants in companion object of Kgl - Adds deprecated annotations on top...

wakaztahir

Allow passing null as glTexImage2d Buffer

1

I tried passing an empty buffer but that didn't work My codebase explicitly passed null and it works on Android, I don't know about other platforms, An android only solution...

wakaztahir

Allow different implementations of TextureResource

1

### Use Case Android has GL calls to allow providing a Bitmap as texture data, Currently you need to copy the bitmap to a buffer before you can pass it...

wakaztahir

I am not sure if this is intended https://github.com/gergelydaniel/kgl/blob/8d57afe2debd483baf840c55c3f4c2f796c7d7c2/kgl-lwjgl/src/main/kotlin/com/danielgergely/kgl/KglLwjgl.kt#L181

wakaztahir

The full method signature is in Android Open GL ES ```java public static void texSubImage2D(int target, int level, int xoffset, int yoffset, Bitmap bitmap) ```

wakaztahir

Put constants in an object

2

This makes them easy to reference, IDE suggests completion when you use that object, Currently they are left in the open

wakaztahir