gerardcl

Results 65 comments of gerardcl

hi @laggardkernel the PR LGTM! I like it! 👍 let me know if you want me to help on anything missing from the list! thanks a ton

hi @xiasanshi, it doesn't since it depends on [aioredis](https://github.com/aio-libs/aioredis-py), which it does not provides support for redis cluster (see readme/docs there).

I like a lot this last approach, since: - by default the jenkinsfile one gets provisioned it is only using `master` -> `dev` indeed - an environment (in ODS) is...

@metmajer @henrjk FYI before providing a PR I would like to get aligned here, will wait! 👍

I see this also related to what is being discussed in https://github.com/opendevstack/ods-jenkins-shared-library/issues/387 , what do you think? One interesting point here is to be also able to run some stages...

Hi @metmajer! and happy new year everyone! 🎊 Happy to help here, but would be good to understand the current implementation's rationale (see `Additional context` in the description) to be...

hi @clemensutschig and @metmajer! I have spoken with @serverhorror, and here I have found the key: https://github.com/opendevstack/ods-jenkins-shared-library/pull/916/files#diff-96df04d4dcbce1a147ac0981b3c1733485a943bb165298cc4be3e61c768b90cdR44 So, my suggestions is to wait for that related PR#916 to be merged,...

After testing recent master merge of PR #916, we can close this issue since https://github.com/opendevstack/ods-jenkins-shared-library/pull/916/files#diff-8ac182f5eaada3eedc19f3865224b0a5c7abf04ca89cc6b2be572844b1e31d77R83 fixes it. We have now again support for multiple components to be scanned by aqua...

@braisvq1996 should we add this somehow in the changelog too? so in the next release this fix also gets included although being implicitly fixed by another issue's PR?

This might break the RM since the image is not owned by ODS nor in the `openshift` namespace. The solution might be required to be managed via PaaS team (which...