Geraint comments

Results 81 comments of


                                            Geraint

Do you have any human readable source code?

Ouch. 😛

Fixes a DoS exploit in the decoder

I'm not sure I'm meant to still have access to an mbed repo, but looks good to me 😛

Better cardinality guesser

Nice - I'll definitely have a good look at this.

Arrows not displaying properly with non-semantic css

Thanks for the bug report - which browser/OS are you using? Does this [demo page](http://geraintluff.github.io/sequence-diagram-html/example-css.html) display incorrectly?

Support pattern flags

The JSON Schema spec says that the value of `pattern` is "a valid regular expression". I believe this is distinct from a regular expression _literal_. All the examples in the...

[tv4] Fix memory leak

Sorry - I'm having trouble seeing the leak here. How was `context` leaking? (There also seem to be some changes making `ValidatorContext` public, which I don't quite understand either. Why...

no name of the `additionalProperty` in the error message

Sorry about this - should be fixed in `1.2.5`.

Validation fails on json schema itself

(I assume you're using "ban unknown properties" mode deliberately.) Huh - so the `"$ref"` keyword is missing from the meta-schema as well as `"format"`. That definitely needs to be fixed.

Could also be an external inclusion, e.g. `tv4.standard-formats.js`? Would just be something like: ``` javascript tv4.addFormat({ 'date-time': ..., 'email': ..., ... }); ``` so people could include it separately (and...

Validation not detecting enum violation

OK, so I can't immediately see the cause of the RangeError, but it does look like you're trying to use a v3 schema (the `type` syntax is off). [This tool](https://github.com/geraintluff/json-schema-compatibility)...