George Xu

Results 15 comments of George Xu

closed with https://github.com/electron-forge/electron-forge-docs/pull/76

Hey! I took a look at the failing test- in the interest of moving the PR forward, we can write the test using a snapshot instead as it seems that...

Hey! The maintainers are taking a look at this, but we're unable to reproduce this on MacOS12.5.1- this is what we are seeing: can you double check that the [demo](https://github.com/mikesongming/electron-forge-demo.git)...

https://github.com/electron/electron/blob/main/docs/breaking-changes.md#default-changed-renderers-without-nodeintegration-true-are-sandboxed-by-default I suspect this error, as individuals above have mentioned stems from the electron 20 sandbox change. This means that you are unable to use `__dirname` in the renderer preload...

Hello! Thank you for your issue. what is the folder path of the exe that isn't being correctly signed? is the `make` command returning any errors? Lastly: can we check...

@carlos-labrador The expected behaviour is such that `/path/to/app/out/make/squirrel.windows/x64/.exe` is signed. In contrast, we do *not* expect `/path/to/app/out//.exe` to be signed.

can you upload the console logs when you run: `DEBUG=electron-windows-installer* yarn make` in your my-app

Hi Carlos, It looks like your script isn't spawning a process with the correct params > the process I'm referring to: ``` electron-windows-installer:spawn Spawning C:\Users\carlos\Documents\electron-projects\my-app\node_modules\electron-winstaller\vendor\Squirrel.exe --releasify C:\Users\carlos\AppData\Local\Temp\si-2022914-59316-1igtq73.xt4hi\my_app.1.0.0.nupkg --releaseDir C:\Users\carlos\Documents\electron-projects\my-app\out\make\squirrel.windows\x64 --loadingGif...

I see! Sorry, oversight by me, forgot about that part of your previous comment. Happy it was fixed!

[54c0d9c](https://github.com/electron-userland/electron-forge/pull/2967/commits/54c0d9c6cf5e220c848417df6c9036c7f7cc270a) commit message is supposed to be: "ran lerna link convert"