georgematheos
georgematheos
(just added a test for this behavior)
@marcoct is this closed by #274 / #282 ?
A few more TODO reminders: 1. Consider renaming `GenericST` to `GenericSerializableTrace` (and maybe same for `DefaultST`). 2. If I'm going to include `DefaultST`, I should test it. 3. I currently...
@marcoct this is now ready for review. During review, could you please look at: - In the documentation, should we list the serialization-related methods as being part of the GFI?...
Re formalisms: I agree with @marcoct that clearly articulating what a distribution, choicemap, trace, etc. is is important, especially when making a change like this. I’m not sure we should...
(copied from what Marco posted in the slack:) Actually --- if-else-end is not implemented yet. I only implemented if-end. This code runs successfully for me: using Gen ``` @gen function...
I should note that these interface changes probably require some significant discussion at some point and may change significantly. Some of this discussion has already happened on the google docs...
> Awesome! > > Btw, I'm assuming this PR supersedes #266, could you please close it if so I think this does supersede that, but this is such a big...
got it. Well, I'll mention some issues and PRs in the main thread, and if/when we merge this we can just close the related PRs manually. (Maybe we should close...