Geoffrey Mureithi

Results 63 comments of Geoffrey Mureithi

What is broken specifically? `J::NAME` allows someone to provide a namespace.

Also, I don't see anything related to tests.

I think you are looking for `--test-threads=1` https://github.com/geofmureithi/apalis/blob/05cbe06253b7aad7f0b8b037027f3adf798a42c3/.github/workflows/redis.yaml#L33

Isn't it better to adjust your tests to fit the code, instead of adding more code just to fit your test requirements? That part was done intentionally, its the approach...

I see your point. Could you consider annotating the parts you have added with `#[cfg(test)]` and `#[doc(hidden)]`? It might also require the tests to be updated and removing `--test-threads=1` from...

Hmm you may be right. I know this is a tricky thing, but could we put a pin on this then I can look at a solution for the end...

Yeah it would not work. This issue is related to https://github.com/geofmureithi/apalis/discussions/191 Let me look into it over the weekend.

To easily achieve this, I think we should just drop the traits `Job` and `Message`. I am considering adding a namespace field on Worker.

Mysql uses `FOR UPDATE` which might have locked some rows.