Geoffrey Mureithi

Results 63 comments of Geoffrey Mureithi

@kt3k I want to get into Deno (I have prior Rust and Node experience), Can I take this one?

Looking at the `main` branch, there is this method. https://github.com/denoland/deno_std/blob/main/node/_events.mjs#L141 @dahlia Am I missing something? FYI, I am a first time contributor to deno 😅.

Let me make an attempt before the end of the week and see how it goes.

@e-kibet I did write integration tests. Running them should tell you whether it still works.

@panarch any update on this? I could pick it up if need be.

Awesome! My current approach would be use a parser, and then iterate through the tokens to generate the final output. There is [sqlformat crate](https://github.com/shssoichiro/sqlformat-rs) which I found has similar functionality...

After a little more research, this crates uses https://github.com/sqlparser-rs/sqlparser-rs so I will work to integrate this feature at that point where I will look for [Value::Placeholder](https://docs.rs/sqlparser/0.39.0/sqlparser/ast/enum.Value.html#variant.Placeholder)

While this PR may work, it does consider jobs already stored.

The idea behind this implementation is inspired by Que https://github.com/que-rb/que/blob/9b264060d81f639d60bc9084ad6cc7dfb8812eba/lib/que/poller.rb#L60-L113 The full context is provided by the lib author here: https://gist.github.com/chanks/7585810 This improvement would hopefully get postgres to 10k/s jobs...

What are your thoughts @joshbenaron ?