Geoffrey Dhuyvetters

Results 22 comments of Geoffrey Dhuyvetters

Is there a quick fix for this one?

https://github.com/duivvv/validate-note Change inherit to true and cause a failed test (rename one of the errors is the easiest way I guess)

working on this one, anybody knows of a way to get the webpack.config.js path in a plugin?

@christophehurpeau wouldn't both options return the plugin path instead of the folder where webpack is invoked?

@christophehurpeau it logs the path to plugin when I run the tests; is it because i ran 'npm test' so process.cwd() is the location where I ran 'npm test' ?

I have some questions / suggestions / feedback. Will get back to you ASAP 🙂 Thanks a lot for the work already!

Been bumping into the same situation, where I'm fetching things based on coordinates. But don't need to store all of the data in the cache

Thanks for the PR :) I think it might make sense to use the Airbnb code style guide here. `CHORD.minorMajor` instead of `Chord.MINOR_MAJOR` etc... What do you think @enjikaka?

reference here https://github.com/airbnb/javascript#naming--uppercase

I see your point, that would probably also mean we would have to change the intervals / scales etc for consistency. I wasn't thinking about the case where you are...