sw4 icon indicating copy to clipboard operation
sw4 copied to clipboard

Discrepancy in refine-el-1.in between github tag and associated tarball

Open crlishka opened this issue 4 years ago • 0 comments

I found an odd discrepancy between the source code with the v2.01 tag and the release tarball made from that tag: the file sw4/pytest/reference/meshrefine/refine-el-1.in for the v2.01 tag is missing a line that does appear in the same file in the sw4-v2.01.tgz release tarball. The missing line is:

developer ctol=1e-10 cmaxit=100 #tighten tolerances to reduce roundoff errors

If this line is missing (as with the v2.01 tagged source), then pytest/test_sw4.py marks test refine-el-1.in as a FAIL because the tolerance check does not pass.

You can see this in the following way:

  • Viewing the SW4 github page in your browser, select tag "v2.01", then traverse to file "pytest/reference/meshrefine/refine-el-1.in". You will see that the above developer line is missing.
  • Alternately, git-clone the repo and "git checkout v2.01", then look at the above file. Again, you will see the above deverloper line is missing.
  • Download sw4-v2.01.tgz from the SW4 github releases page. Expand the tarball, then examine the above file. The above developer line will be present.

Given that Github creates a corresponding tag and tarball (containing the source code for that tag) when one creates a new release, it is very odd that the source code for the tag and tarball do not match.

A couple other notes:

  • The master branch has the developer line in refine-el-1.in, as a commit was done on master right after the v2.01 to add this.
  • While v2.01 is the most recent non-RAJA release, I also noticed the developer line missing in tab v2.1-b.

crlishka avatar Jun 16 '20 23:06 crlishka