Proofreading changes

[Robinlovelace]

• [x] Foreword (2nd Edition): RL
• [x] Preface: RL
• [x] 1 Introduction: RL, JM, JN
• [x] 2 Geographic data in R: RL
• [x] 3 Attribute data operations: RL
• [x] 4 Spatial data operations: RL
• [x] 5 Geometry operations: JM
• [x] 6 Raster-vector interactions: JN
• [x] 7 Reprojecting geographic data: JN
• [x] 8 Geographic data I/O: JN
• [x] 9 Making maps with R: JN
• [x] 10 Bridges to GIS software: JN
• [x] 11 Scripts, algorithms and functions: JM
• [x] 12 Statistical learning: JM
• [x] 13 Transportation: RL
• [x] 14 Geomarketing: JM
• [x] 15 Ecology: JM
• [x] 16 Conclusion: RL, JM, JN
• [x] References: RL, JM, JN

[Nowosad]

Chapters 6, 7, and 8 are done: https://github.com/geocompx/geocompr/pull/1119, https://github.com/geocompx/geocompr/pull/1120, https://github.com/geocompx/geocompr/pull/1121. I plan to work on Chapters 9 and 10 tomorrow.

[Nowosad]

Chapters 9 and 10 are done: https://github.com/geocompx/geocompr/pull/1125, https://github.com/geocompx/geocompr/pull/1126/

Edit: also Chapter 16: https://github.com/geocompx/geocompr/pull/1127

[Nowosad]

There are two remaining issues:

1. Several times, the comment is "AU: Please move this line of text to the next page" -- is seems like a lost battle, as when we move one line, then another problematic lines could occur)
2. References also contain some comments from the proof reader

[Robinlovelace]

AU isn't for us I think.

[jannes-m]

I plan to start the proof-reading today in the evening. @Robinlovelace I would start with the chapters that are solely assigned to me. When I am done with those, I'll also have a look at jointly assigned chapters.

[jannes-m]

The reviewer points out (ch5):

Is it OK that you are spelling "gray" with an "a" here but "grey" with an "e" in the code below? Please do a global search for the word you wish to change (if you decide to do so).

I guess he has a point here, if you agree I would replace all instances of grey (BE) by gray (AE).

[jannes-m]

c5 in #1128

[Robinlovelace]

I guess he has a point here, if you agree I would replace all instances of grey (BE) by gray (AE).

Agreed.

[jannes-m]

c12 is done in https://github.com/geocompx/geocompr/pull/1136

[Robinlovelace]

Great job, thanks Jannes! See a couple of comments in there, looking great.

[Robinlovelace]

How are the references looking now @Nowosad, almost done, right?

[Robinlovelace]

Then it's just one more chapter, you're down for that @jannes-m, and we're good to go. Is #1137 ready to merge yet also?

[jannes-m]

I will finish the review of my last two chapters this weekend!

[Nowosad]

@Robinlovelace I tried to fix all of the references a few days ago

[Robinlovelace]

@Robinlovelace I tried to fix all of the references a few days ago

@Nowosad were you were successful?

We can check another one of the check boxes above if so.

[Nowosad]

Hi @Robinlovelace -- I just rendered a new pdf, I looked at the all of the references, and made a few edits on Zotero. Please reexport the bib file and then the references should be fine.

[Robinlovelace]

See https://github.com/geocompx/geocompr/commit/589a7e6b41c28f3db0ac60d5d2daa8c4f6871b7d there are a couple of additional tweaks I'd like to make but this is basically done.

[Nowosad]

Great -- thanks!

[jannes-m]

#1137 and #1139 are ready for review

[Robinlovelace]

All good and merged. @jannes-m and @Nowosad I've emailed you. We should be able to close this issue Tuesday, after submitting the updated post-proofreading changes. Almost there :rocket:

[Nowosad]

Hi @Robinlovelace I just have about 10 minutes, and started skimming thorough the pdf:

1. Page 227: "the simple ‘lifeApp’ example (Figure ??)" -- this seems to be the only ?? issue
2. Page 352: something is wrong with the italics

[Nowosad]

I think I fixed the both issues.

[Robinlovelace]

You're ahead of the game, thanks Jakub as was just about to work on a fix.