Petr Pučil
Petr Pučil
I need to check this once I'm on my computer, if it works as before or not.
> Such a change seems reasonable and I think we shouldn't does anything with that. Well, I wholeheartedly agree, as the stuff like ```js const KaitaiStructCompiler = require('kaitai-struct-compiler'); const compiler...
> I would be super grateful if this feature was included in the 0.9 release Unfortunately, this is no longer possible - we released 0.9 the day before yesterday (on...
FWIW, I recently fixed an issue with the unused `i` variable in Go - see the fix and the comment: https://github.com/kaitai-io/kaitai_struct_compiler/blob/8913518145cb1dc6efb3b6b40d115cb0a256c813/shared/src/main/scala/io/kaitai/struct/languages/GoCompiler.scala#L324-L329 In Go, an unused variable is even a fatal...
@jocelynke Could you please push your changes to your branch [`jocelynke:regex_support`](https://github.com/jocelynke/kaitai_struct_compiler/tree/regex_support) so we can see the changes you've made? It seems that you're just marking the things as resolved, but...
I just realized that it isn't enough to just initialize the `_it` variable to simulate the conditions while deserialization. A simple search in the formats repository shows how the `repeat-until`...
@UnePierre: > All predecessors must not fulfill the condition, unless there is some inconsistency there. That also needs checking, I assume? Yes, thanks for pointing it out. I'll follow with...
Unfortunately, I have to disagree with this one, please see https://github.com/kaitai-io/kaitai_struct/issues/69. Adding "force parentheses" operators seems to be a misunderstanding how AST works. These parentheses add no information to the...
@GreyCat Have you looked at the code? What's the problem? You hinted in https://github.com/kaitai-io/kaitai_struct_compiler/pull/192#discussion_r368288211 that you're not a fan of the idea of `CodeLiteral`. I also don't like it much,...
Problem solved in https://github.com/kaitai-io/kaitai_struct_compiler/commit/939cf98d495b941920753dad379a65346a1d8f2e using [`Ast.expr.InternalName`](https://github.com/kaitai-io/kaitai_struct_compiler/blob/939cf98d495b941920753dad379a65346a1d8f2e/shared/src/main/scala/io/kaitai/struct/exprlang/Ast.scala#L77-L78)