kaitai_struct_compiler icon indicating copy to clipboard operation
kaitai_struct_compiler copied to clipboard

Published 20 hours ago • verified publisher icon kaitai-io

Java: add ability to report positions relative to root stream and add PositionInfo interface

Open Mingun opened this issue 4 years ago • 7 comments

New interface PositionInfo introduced to allow to get position information without reflective access in generic way. Closes https://github.com/kaitai-io/kaitai_struct_java_runtime/issues/27

Store offset of streams from begin of root stream in offset field. Fixes https://github.com/kaitai-io/kaitai_struct_java_runtime/issues/26

Depends on runtime changes from https://github.com/kaitai-io/kaitai_struct_java_runtime/pull/28 and test changes in https://github.com/kaitai-io/kaitai_struct_tests/pull/77

Examples of message, file, generated before this PR and after (with --debug key): messages.zip

List of all related issues/PRs:

  • [ ] https://github.com/kaitai-io/kaitai_struct_java_runtime/issues/26 -- issue with feature description
  • [ ] this one for compiler
  • [ ] https://github.com/kaitai-io/kaitai_struct_java_runtime/pull/28 for runtime
  • [ ] https://github.com/kaitai-io/kaitai_struct_tests/pull/77 for tests

Mingun avatar Feb 23 '20 20:02 Mingun

Can you review this please? I want to move on in improving kaitai_struct_gui, but this and #191 are now blockers for that.

Mingun avatar Feb 28 '20 14:02 Mingun

Let me remind you of myself again. I would be happy if these changes were merged before 0.9 release.

Mingun avatar Aug 09 '20 05:08 Mingun

@GreyCat , @generalmimon I would be super grateful if this feature was included in the 0.9 release

Mingun avatar Oct 18 '20 04:10 Mingun

I would be super grateful if this feature was included in the 0.9 release

Unfortunately, this is no longer possible - we released 0.9 the day before yesterday (on October 16, 2020; see https://kaitai.io/news/2020/10/16/kaitai-struct-v0.9-released.html).

I would also like to retrospectively add a couple of things to the 0.9 version (I especially regret breaking backward compatibility on the contents key with repeat and the disappearance of contents in the Graphviz output: comparison), but you just can't delay the release to the point when all bugs are resolved or all nice-to-have features are fully implemented (because that's never gonna happen). We've already waited 2.7 years and that had been already quite embarrassing.

generalmimon avatar Oct 18 '20 08:10 generalmimon

Well, no one forces wait 3 years until version 0.10. It can be released more quickly :)

Mingun avatar Oct 18 '20 14:10 Mingun

So, what's the verdict on my PRs? Can I expect any comments in them?

Mingun avatar Nov 01 '20 09:11 Mingun

Come on, guys! Is there no one interested in the development of Java backend?

Mingun avatar Nov 08 '20 06:11 Mingun