Petr Pučil

Results 327 comments of Petr Pučil

To me, `Id` and `Label` were very clear names (especially "label" conveys very well that it is a text identifier). `Cast` and `Variant` not so much. The only trifle with...

@sandreenko: > Offtopic: https://ide.kaitai.io/ for acrhive/android_sparse.ksy looks broken: > > ``` > Parse error (ValidationNotEqualError): not equal, expected [58,255,38,237], but got [80,75,3,4] > Call stack: Error > at new KaitaiStream.ValidationNotEqualError...

@sandreenko: > > I wouldn't recommend using Kaitai Struct to access the files in that filesystem. > > Why? If you want to go down this path, feel free to...

@Mingun: > I've open a https://ide.kaitai.io/# in Firefox, open console and put the following code to it: > > (...) > > but webide still does not see it. You...

@GreyCat: > Is there any merit in having enums based off signed integers at all? I mean, why don't we switch to "everything generated is based off ulong"? Because then...

@GreyCat: > Sadly, our enum specs are not super extensible to allow this, so it will be likely quite ugly change :( True, but I think the fact that we...

@GreyCat Could you please continue with the review?

@jhgorse: > Looks like we are 359 commits behind master. > There are also 89 merge conflicts to master. Don't worry, this will be in 0.11 no matter what -...

You might want to take a look at, for example, https://github.com/xmlrunner/unittest-xml-reporting from the Python ecosystem to see how it handles this situation: ```py import unittest class TestRepro(unittest.TestCase): def test_str_compare_null_byte(self): actual...

> Could you provide a simple example that reproduces this problem? I think I've found one: ```ksy meta: id: value_inst_array instances: v: value: '[1000, 2000, 3000]' ``` After expanding `v`...