Petr Pučil

@bowbahdoe: > Its just a compromise to not have to upgrade past Java 8. That's what I didn't know: if `moditect-maven-plugin` is required to support Java 8, then we really...

Surprisingly, my initial intuition that it might be possible to just include the "module info" into the JAR and have Java 8 ignore it but enjoy the benefits of modules...

@GreyCat: > I don't mind either of these changes, but what I ideally want us to have is reproduction of any kind of problem in CI. I agree. I don't...

@GreyCat Please take another look. I added [`include-what-you-use`](https://github.com/include-what-you-use/include-what-you-use) to CI and fixed the "violations". I only took the easy way to install it - https://packages.ubuntu.com/jammy/iwyu. That means we're using the...

I should note that IWYU suggests some changes in `unittest.cpp` even after the fixes in https://github.com/kaitai-io/kaitai_struct_cpp_stl_runtime/pull/72/commits/cd145314bab8f269c1e605a22689370602ccfb1b: ```console /home/runner/work/kaitai_struct_cpp_stl_runtime/kaitai_struct_cpp_stl_runtime/tests/unittest.cpp should add these lines: #include // for Message #include // for TestPartResult...

@GreyCat This is now ready to merge - let me know if you have any objections.

@pfroud: > What do you think about this: > > * Find sequential items using `seq_fields`. The order of the sequential items will match the order in the KSY file....

Try updating to the latest development compiler version. I can spot a known problem to me in the code which always occurred when using type-switching with user types and disabled...

There's also an important thing to consider: creating a stream on processed bytes, for example with `process: zlib` (kudos to @GreyCat and his https://github.com/kaitai-io/kaitai_struct/issues/331#issuecomment-361432895 that reminded me of it). The...

> Is Windows even supported? Yes, but the runtime is currently only adapted for the Microsoft Visual C++ compiler to work out of the box. See `kaitaistream.cpp`: https://github.com/kaitai-io/kaitai_struct_cpp_stl_runtime/blob/cb09b3a84c7e905c6a3fecfe9617cf864d9af781/kaitai/kaitaistream.cpp#L12-L23 > but...