Petr Pučil
Petr Pučil
> It's documented in https://doc.kaitai.io/serialization.html, but ultimately our goal obviously would be not supporting two separate forks, but having one that does everything. Of course. I'd love to do this...
Also I've just extended the description of `--read-write` a bit to match the current situation, hopefully that's OK ([`JavaMain.scala:60-62`](https://github.com/kaitai-io/kaitai_struct_compiler/blob/f1dc857302bc30a2a259f9e6d7dff12674f451b8/jvm/src/main/scala/io/kaitai/struct/JavaMain.scala#L60-L62)): ```scala opt[Unit]('w', "read-write") action { (x, c) => c.copy(runtime = c.runtime.copy(readWrite...
> Also merged https://github.com/kaitai-io/kaitai_struct_python_runtime — see [kaitai-io/kaitai_struct_python_runtime@704995a](https://github.com/kaitai-io/kaitai_struct_python_runtime/commit/704995acdb2f114e15809cf5f469e3a80a2dddad). Seems a bit weird to me to do this as a fast-forward merge, but OK.
I've just resolved the merge conflicts on branch https://github.com/kaitai-io/kaitai_struct_compiler/tree/serialization.
@GreyCat Any comments? Do you think this BC break is acceptable, and/or do you have any ideas to make it less "painful" for the users?
@GreyCat Thoughts?
This was implemented in https://github.com/kaitai-io/kaitai_struct_compiler/pull/264. Basically the only disadvantage of this whole idea is the BC break, which is not mitigated in https://github.com/kaitai-io/kaitai_struct_compiler/pull/264 in any way. In theory, there are...
@GreyCat: > For the record, it was never advertised as "it will generate docstrings". Well, the user guide says that docstrings added in `doc` keys to attributes will exported into...
Although the main problem of this issue (invalid string literals like `"path\to\format.ksy"` in the JSON output) has been resolved in KSC 0.8, there is still the compiler's behavior of converting...
Apparently, the reason why the compiler converts the input paths is because it initially reads the given command-line .ksy path arguments to [`java.io.File`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html) objects (see [`JavaMain.scala:38`](https://github.com/kaitai-io/kaitai_struct_compiler/blob/7071a9de11de3bafa711b6eb21961bbf7680623a/jvm/src/main/scala/io/kaitai/struct/JavaMain.scala#L38)) and later uses their...