Petr Pučil
Petr Pučil
It's good that you resolved https://github.com/kaitai-io/kaitai_struct_javascript_runtime/issues/27 in https://github.com/kaitai-io/kaitai_struct_javascript_runtime/pull/26/commits/4a1b441feeee48cda6c4573368d8670a63d4586e, but that commit should ideally contain `Fixes #27` or `Fixes kaitai-io/kaitai_struct_javascript_runtime#27` (see GitHub [Autolinked references and URLs](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#issues-and-pull-requests)) in the commit message so...
> I would be glad if this will be merged I understand, but I can't promise anything. I'm currently already well behind schedule with things I need to do. I...
`m_io` has type `std::istream`, which is [defined as `std::basic_istream`](https://en.cppreference.com/w/cpp/header/istream#firstHeading). I see that [`std::basic_istream`](https://en.cppreference.com/w/cpp/io/basic_istream) is an abstract class that doesn't have any `close()` method, so it's no surprise that it can't...
@RazrFalcon: > Weirdly enough, when you open this SVG as a link from github - it's broken. But opening a local file works just fine. FWIW, the reason is logged...
@LmpOSX Yes, as @Mingun points out, you're missing a closing parenthesis. Decent editors like VS Code can actually visualize this nicely (although not in a string literal in YAML mode,...
Honestly, don't hold your breath until this pull request is merged. I can already see that there are several issues that will have to be solved, I'll have to make...
@cmilhaupt: > Is there anyway in the KSY file definition to make these generate as a `uint8_t` to save some space? You have roughly the following options: 1. Instead of...
I'm also not sure about this change. I don't think every `kaitai-io` repo needs to be a submodule of `kaitai_struct`. Maybe it's somewhat good for visibility to add `ksy_schema` (`doc`...
The general answer is that this is caused by a mismatch between the KS compiler version and the KS C++ runtime library version. If you use a released "stable" compiler...
To be honest (cc @GreyCat), I personally don't see the benefits of changing the type of parameter `src_enc` from `const std::string` to `const char *`. According to https://github.com/kaitai-io/kaitai_struct_cpp_stl_runtime/pull/61#issue-1800823130, it's supposed...