Robbie Gemmell

I added some commits fixing many of the code items I commented on earlier. I also switched it to the current SNAPSHOT since the staging repo was dropped when the...

As discussed on the offshoot PR on Franz' fork repo back then  (https://github.com/franz1981/activemq-artemis/pull/15), I'd still be inclined to make the deps optional/provided even now, especially given it is disabled by...

Personally I wouldnt do either of those. I would either proceed without using hard deps, or wait for 4.2 without hard deps. Given the Pr has sat for 3.5 years...

Sure, next time a release is being done the version of Netty used will be updated to something recent (e.g this PR is already stale and 4.1.109 is the current...

I pushed a couple of commits making similar changes as I had on the earlier PR, to fix some regressions since then. That leaves the comments around the missing licence...

Beyond those comments, I was surprised I didnt see any test changes around the change in Netty default for hostname verification in 4.2. Either the Artemis code already handles [enabling...

The java version rule is just about the JVM running the enforcement, i.e the current runtime. It has nothing to do with the compiler settings or what the build output...

> This change looks good to me for the enforcer. > > However, if we merge it, it means Jenkins will fail. I suggest to update `Jenkinsfile` as part of...

Doesnt saying they won't benefit from a new release somewhat overlook how they are actually used and expected to behave by many users? Users will often only have a Log4j...

> > Doesnt saying they won't benefit from a new release somewhat overlook how they are actually used and expected to behave by many users? > > Users will often...