Robbie Gemmell

I would probably make them mutually exclusive personally, as they will most likely never agree exactly on when to block and unblock so it seems odd to set both. Although...

>I would probably make them mutually exclusive personally, as they will most likely never agree exactly on when to block and unblock so it seems odd to set both. Although...

> > > @gemmellr > > > Since the existing functionality uses 'max-disk-usage' as a name, I think something like 'min-disk-...' would be more consistent than 'min-free-disk-bytes' is. I wouldn't...

The issue with respecting both if set is that the existing max-disk-usage has a default and so its essentially always on even without config, unless manually disabled with config, plus...

> > Can you check on testSimpleTickforMinDiskFree(). it's always failing. > > That test is just a following copy of testSimpleTickforMaxDiskUsage() (initally testSimpleTick()) > > The test fails because I...

> I got `BUILD SUCCESS` with `mvn -Pdev install -Derrorprone`. Not sure if it's the same with the Github workflow. Please help activate the workflow. > I cant approve the...

I believe the NMS AMQP folks were basing their behaviour here on Qpid JMS like much of the code, in which case the MODIFIED_FAILED_UNDELIVERABLE (shorthand for undeliverable-here) is the expected...

A start would be to create a JIRA to allow tracking the issue, rebasing your commit against master (rather than merging master), and reference the JIRA in your commit (see...

Thanks. Hopefully one of the C-inclined folks will be along to review the change.

Note that any progress here will need a new PR with this one being closed, as the code has now migrated to its own repo, which is mirrored at: https://github.com/apache/qpid-cpp