Thomas Scholtes

Results 36 comments of Thomas Scholtes

I totally missed that we only require these for dependencies :facepalm:. We can make `mediafile` and `confuse` explicit test dependencies with `test_requires`. Then the tests with beets 1.4.7 should pass....

Seems link a good idea. `os.link()` is what we would need to use. If you feel like, please open a PR, @nichobi. I’m happy to help with any questions.

I wasn’t aware of `beets.util.hardlink()`. Makes sense to use it. Thanks for the analysis on the different approaches. I think the last one makes the most sense. We could also...

> In addition, hardlinking by default changes the behaviour when the files in the alternative collection are modified (e.g. by a player writing rating tags): Currently, this will not affect...

> I'd say, all of `symlink`, `hardlink`, `reflink` could be implemented (or one for now, adding others as requested), everyone could then choose his or her preferred method. This seems...

> Stepping back a little, I think it would be better (and easier to implement) to have a separate alternatives.name.embed option For me this seems to be the right way...

Thanks for tackling this, @pkel! This is already a great start. The next step woulds be to document this feature in `README.md` and write some tests. The documentation should mention...

I’d go with 1) over 2). The main reason is that under these unexpected we want to notify the user early and visibly. We also want to avoid doing more...

Thanks for the suggestion. I think this is a reasonable feature to have. @wisp3rwind, do you want to have a look at this since you added support for album art?

Thanks for the report, @RollingStar. It makes sense to have the number of converter threads configurable. You seem to already have had a look at the code. If you would...