Gustavo Santos
Gustavo Santos
I've added the cypress test and would be delighted if you could review it - It is the first time I work with cypress :). Also, I've removed the try/catch...
I didn't let the button in the center of the clickable area because it would lose the alignment with the heading, but if you prefer it to the center, I...
Thanks for the quick feedback! When they figure out, I'm happy to help.
I've updated the code following @janogarcia suggestion. The close icon is centered within the 32x32 target area:  And the target area is at 24px from the the modal window...
@tlabaj I've updated the branch for this PR. Also, I noticed some snapshot tests related to context selector are failing. Once my changes are approved, should I update the snapshots?...
@tlabaj Thanks for the feedback! I updated the snapshots. @mmenestr your suggestion is great! I believe that when I delete my input in the search, the filter should reset because...
I would like to work on this issue :)
@nicolethoen to address this issue, I've made a change to the props in the `LoginForm.tsx`. I'm not sure about the side effects of this change, but all the tests have...
@nicolethoen thanks for the guidance. I've implemented the pattern to forward refs similar to the one in `Button.tsx` and it didn't worked. I tried too with similar patterns I've found...
@nicolethoen Thanks for the feedback. Already implemented the changes :)