Jeff Geerling comments

Results 1857 comments of


                                            Jeff Geerling

Role fails if docker repository is already on the host but wasn't added by ansible

Since this role is meant to be used on a clean installation where Docker has not been set up before, I'm more tempted to close this as a 'wontfix', just...

Role fails if docker repository is already on the host but wasn't added by ansible

I'd be willing to merge a PR that makes the filename configurable — that issue (#101) was an issue, not a PR though?

Role fails if docker repository is already on the host but wasn't added by ansible

Ah, I see the PR is https://github.com/geerlingguy/ansible-role-docker/pull/102/files — that PR needs some tweaks, but something similar could work. I would like to see the default either be `""` and add...

Role fails if docker repository is already on the host but wasn't added by ansible

I just released a 5.0.0 with some breaking changes, so I think for now we'd keep the same for compatibility with existing role users, but we could consider changing the...

Add ability to look up the latest docker-compose version from Github API

I like this.

Add ability to look up the latest docker-compose version from Github API

Hmm... is there an easy way to work around that?

added rootless mode

This seems like a nice addition.

Document why Chrome is needed (firefox seems to print fine to PDF)

Ditto—I just tested in Chrome, FireFox, and Safari on Mac, and Chrome on Mac doesn't actually allow 'show backgrounds' in the print options. Safari and FireFox do, but only FireFox...

Document why Chrome is needed (firefox seems to print fine to PDF)

Here are the settings I used with FireFox 47, and they worked great to produce a 16:9 aspect ratio presentation export (note that I created a custom page size with...

Put installing the required gems in the readme

+1 to this; it wasn't clear to me that I had to add any other gems.