ansible-role-docker icon indicating copy to clipboard operation
ansible-role-docker copied to clipboard

Add ability to look up the latest docker-compose version from Github API

Open robinreinhardt opened this issue 4 years ago • 9 comments

This small changes add the ability to get the latest docker-compose version from Github API when docker_compose_version is "latest"

robinreinhardt avatar Jun 18 '20 18:06 robinreinhardt

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Sep 17 '20 03:09 stale[bot]

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

stale[bot] avatar Oct 17 '20 04:10 stale[bot]

I like this.

geerlingguy avatar Nov 11 '20 23:11 geerlingguy

This pull request is no longer marked for closure.

stale[bot] avatar Nov 11 '20 23:11 stale[bot]

This issue is no longer marked for closure.

stale[bot] avatar Nov 11 '20 23:11 stale[bot]

This pull request is no longer marked for closure.

stale[bot] avatar Nov 11 '20 23:11 stale[bot]

Please be aware that this code is now broken due to the release of compose v2 i.e. when you now try to get the latest release you'll receive a 404. This is due to the fact that in compose v2 the assets are renamed from e.g. docker-compose-Linux-x86_64 to docker-compose-linux-amd64.

jorianvo avatar Sep 28 '21 15:09 jorianvo

Hmm... is there an easy way to work around that?

geerlingguy avatar Apr 04 '22 14:04 geerlingguy

Unfortunately I guess this can not be solved easily. The download link structure is really messed up across the versions. Here what I got so far:

version 1: version number without "v", Linux, x86_64 version 2.0.0: version with "v", linux, amd64 since version 2.0.1: version with "v", linux, x86_64

That's why it's not possible to downgrade the version from 2 to 1 like mentioned on #378

Gladly report if someone can create a logic for this link structure.

Perhaps we should consider deprecating compose version 1 in this role.

robinreinhardt avatar Oct 28 '22 20:10 robinreinhardt